search

denisenkom / pytds

Python DBAPI driver for MSSQL using pure Python TDS (Tabular Data Stream) protocol implementation
MIT License
190 stars 52 forks source link

Federated Auth #151

Open aersam opened 1 year ago

aersam commented 1 year ago

Would fix #135

aersam commented 1 year ago

The login packet is where I'm stuck. seems to be quite complicated to get the offsets and so on right

denisenkom commented 1 year ago

Thank you for submitting this pull request. I need following in order to merge it:

  1. Did you test this change with actual MSSQL server with this configuration?
  2. Add unit test for that code
  3. Get Appveyor tests to pass
saurabh500 commented 2 months ago

As part of the Feature extension negotiations, SQL server also provides the Audience for which the Access token should be provided, along with bunch of other information. Is it possible to bake that into the APIs, so that the users can use the audience of the token, negotiated with the SQL server? Or do you think that's orthogonal to this PR and I should open a different issue?

bowleri commented 1 week ago

The login packet is where I'm stuck. seems to be quite complicated to get the offsets and so on right

I have implemented and created #166