Added check for incompatible fzf version

denisidoro / navi

An interactive cheatsheet tool for the command-line

Apache License 2.0

14.61k stars 489 forks source link

Added check for incompatible fzf version #888

Closed tolik518 closed 3 months ago

tolik518 commented 3 months ago

Navi currently uses fzf with the parameters fzf --preview-window up:2:nohidden while nohidden was added to fzf in version 0.23.1.
Lots of popular distros, like Ubuntu 20.04 or Fedora 30 still distribute fzf 0.20.0 which leads to tickets like #447, #577, or #805.

This PR adds a clear message stating whats wrong instead of forwarding the invalid preview window layout: up:2:nohidden error message to the end user.

welcome[bot] commented 3 months ago

Thanks for opening this pull request!

jackandroselv commented 3 months ago

您好！您的邮件我已收到，我会尽快的查阅邮件。谢谢您的来信！

welcome[bot] commented 3 months ago

Congrats on merging your first pull request!