search

dennis-tra / pcp

📦 Command line peer-to-peer data transfer tool based on libp2p.
Apache License 2.0
1.07k stars 57 forks source link

Attempting to transfer a directory error does not exit on the receiving peer #7

Open jakehemmerle opened 3 years ago

jakehemmerle commented 3 years ago

First of all, I fucking love the simplicity of this app. I just transferred some files between two computers and it was so simple. Thank you for making it.

On the sending side, the peers connect and authenticate, then I get the error:

Peer connected and authenticated!
Error transferring file read BraveSoftware: is a directory

Then, the sending side exits.

On the receiving side, I receive no error.

Looking for peer camp-match-exhaust-fire...
Peer connected and authenticated!

and it does not close.

It seems the following behavior should be expected: 1) pcp should either wrap/compress/file-ify the folder before sending (and unwrap it on the receiving side) 2) pcp should throw an error as soon as it sees the input is a folder, before it connects and authenticates to the peer.

dennis-tra commented 3 years ago

Hi @jakehemmerle ,

awesome that you're checking out the tool :)

Today I created a couple of work items that I want to address for a 1.0 release (list is not yet complete). I just moved the Folder Transmission card up in the priority.

I'm definitely planning to add the ability to transfer directories so I think your point 2. would be the quick fix and your point 1. the proper feature.

Thanks for reporting!