search

denoland / deno-astro-adapter

A Deno adapter for running Astro applications on the Deno runtime.
https://npm.im/@deno/astro-adapter
MIT License
84 stars 19 forks source link

fix image service #7

Closed alexanderniebuhr closed 7 months ago

alexanderniebuhr commented 1 year ago

We have introduced a regression in astro implementing this default overwrite: https://github.com/withastro/astro/blob/main/packages/astro/src/integrations/index.ts#L243-L246

Therefore we will need to remove it in one of the upcoming minors. That however would lead to breaking setups of the deno adapter if users don't have the noop image service defined themselve. I suggest to add the overwrite in the integration itself. The overwrite is needed, because deno does not support sharp or squoosh as a edge runtime.

joshgillies commented 11 months ago

This may no longer be required now that sharp@0.33.0 ships with a wasm binary. https://github.com/lovell/sharp/issues/3750#issuecomment-1751172728

We may instead just need to add explicitly the updated dependency to our project package.json.

npm i sharp@latest -S