Feature - Add article readtime

denoland / deno_blog

Minimal boilerplate blogging.

MIT License

477 stars 100 forks source link

Feature - Add article readtime #74

Closed JLCarveth closed 2 years ago

JLCarveth commented 2 years ago

As per Issue #59, displays the calculated article read time. Can be disabled by using the disableReadtime option.

JLCarveth commented 2 years ago

This is my first real PR to an OS repo, so please let me know if I did something horribly wrong 😅

JLCarveth commented 2 years ago

3 of the tests are failing, specifically when it's looking for <time ... within the post body. However I tested and these were failing before my changes as well. I could likely fix that but it would be a new PR.

rojvv commented 2 years ago

@JLCarveth Can you run

deno test

and investigate what's wrong with it?

rojvv commented 2 years ago

@ije @bartlomieju Approve the workflow to be run so we can see if there's any problem.