search

denoland / website_feedback

For reporting issues & suggestions for deno.com and deno.land
9 stars 1 forks source link

It's hard to read that the font used in the official Deno website. #43

Open kyoh86 opened 1 year ago

kyoh86 commented 1 year ago

It is difficult to distinguish between upper and lower case letters that the fonts used in code blocks and code fragments on the official Deno website (deno.land) image

magurotuna commented 1 year ago

Thanks for the valuable feedback. Just to clarify, what OS do you use? I'm on macOS and Deno.FileInfo renders like this, which doesn't seem problematic for me.

Deno.FileInfo

Another example from Deno.inspect

Deno.inspect
kyoh86 commented 1 year ago

I'm using Windows 11.

kLiHz commented 4 months ago

It seems deno.land has a font-family: Menlo, Monaco, "Lucida Console", Consolas, "Liberation Mono", "Courier New", monospace, Menlo, Monaco, Lucida Console, Consolas, Liberation Mono, Courier New, monospace for code blocks.

MacOS is shipped with Monaco so I think @magurotuna's browser picked that up. But I seems to got this issue too since it resolved at "Lucida Console" on my laptop (Windows 10).

Maybe the problem can be solved by just removing "Lucida Console". Consolas may not be the best, but at least it has a bigger distinction between upper and lower cases.

kyoh86 commented 3 months ago

@kLiHz Thanks! Tried to remove , "Lucida Console", , Consolas , Lucida Console and , Consolas from style, I can read them so clearly!

@magurotuna So I also propose to deno team to remove them

magurotuna commented 3 months ago

Thanks for investigation! Can I ask one more question; do you (as windows users) find the code blocks in https://fresh.deno.dev/docs/getting-started/form-submissions also difficult to read? I guess in Windows Consolas font is applied to this doc, instead of Lucida Console. I am wondering if just removing Lucida Console from font family will be sufficient, because Consolas appears in the default settings provided by twind (tailwind library we use in many places). If the default setting is fine, we'd simply like to leverage that.

kyoh86 commented 3 months ago

@magurotuna Thanks for response and more easy sample. I think that Consolas is not so bad, and it's better than Lucida Console. If Consolas is removed, Courier New is used. While it's subjective, I think Courier New can be harder to read than Consolas, especially because its thin lines might make it less readable in HiDPI environments.

magurotuna commented 3 months ago

@kyoh86 Thanks for clarification! Then we'll remove Lucida Console from the font family so windows users can see Consolas font to be used.