denshoproject / ddr-cmdln

Command-line tools for automating the Densho Digital Repository's various processes.
Other
0 stars 2 forks source link

ddr-pubcopy should only copy files matching the selected DDR file roles #161

Closed GeoffFroh closed 4 years ago

GeoffFroh commented 4 years ago

ddr-pubcopy currently has four flags to select file types -- access, master, mezzanine, and transcript.

The command should only support the following DDR file roles:

When a role is selected, the command should copy both the binaries in that role and the matching access files (e.g., ddr-densho-2-mezzanine-45aad3499c.tif and ddr-densho-2-mezzanine-45aad3499c-a.jpg).

As is the case now, the command should only copy binaries where the parent entity is status==completed and public == 1, and the binary itself has public == 1. (Enhancement: maybe a --forceall flag that copies unpublished, private binaries as well)

gjost commented 4 years ago

So,

gjost commented 4 years ago

Note that ddr-pubcopy does not check status or public - it just copies whatever is there. The helptext says to run this after filtering a collection.

GeoffFroh commented 4 years ago

We should have the command check status and public if possible. We haven't used ddr-filter in the publication workflow for several years.

Please take a look at feasibility and time-required.

gjost commented 4 years ago

I can add the checks. Shouldn't take too long.

gjost commented 4 years ago

Fixed in ddr-cmdln commit 837b1ee for package ddrlocal-develop_2.8.8-2~deb9.

pkikawa commented 4 years ago

fixed in version 2.8.9 MA

sarabeckman commented 4 years ago

Successfully ran ddr-pubcopy on ddr-develop_2.8.9-5.