department-of-veterans-affairs / diffusion-marketplace

Diffusion Marketplace source code
https://marketplace.va.gov
7 stars 10 forks source link

dm-5157 public user bio page #1117

Closed PhilipDeFraties closed 2 weeks ago

PhilipDeFraties commented 2 weeks ago

JIRA issue link

https://agile6.atlassian.net/browse/DM-5092

Description - what does this code do?

Adds endpoint and page for public user bio

Testing done - how did you test it/steps on how can another person can test it

  1. Update a user to granted_public_bio: true
  2. Sign in as that user, go to the /edit_profile page and fill out the public bio fields
  3. Go to /bios/{user.id}-{user.alt_first_name}-{user.alt_last_name} (really anything after the id works as it is removed from the params in the controller action, this will allow links to show the fellows' names without needing to account for duplicate names or lack of presence of alt names)
  4. Verify the user's public bio information and avatar render on the page renders as expected (placeholder image if no avatar), compare with the mockup Note: the name at the top of the page will utilize the alt names if available but default to the normal name values if not

Screenshots, Gifs, Videos from application (if applicable)

Screenshot 2024-11-13 at 2 28 13 PM

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

Definition of done