search

department-of-veterans-affairs / gi-bill-comparison-tool

Rails delivered version of the GI Comparision Tool.
7 stars 9 forks source link

ITT Tech Institute-Pittsburgh (249B0438) #326

Closed ericks24 closed 8 years ago

ericks24 commented 8 years ago

itt tech pittsburgh

@saintsoup52 We are receiving complaints from School Certifying Officials and ELRs about not being able to pull up this facility on Comparison Tool. The attached screen shot is what comes up when selecting ITT Tech Institute-Pittsburgh. The school is on data dahboard.

mphprogrammer commented 8 years ago

The latest xls data file has those schools listed as ITT Technical Institute ...

mphprogrammer commented 8 years ago

screen shot 2016-03-02 at 2 14 29 pm

saintsoup52 commented 8 years ago

ITT Tech was the old school name... remember we aligned the school names with Dept of ED:

https://www.vets.gov/gi-bill-comparison-tool/institutions/profile?military_status=veteran&spouse_active_duty=no&gi_bill_chapter=33&cumulative_service=1.0&enlistment_service=3&consecutive_service=0.8&elig_for_post_gi_bill=no&number_of_dependents=0&online_classes=no&source=search&institution_search=ITT%20Technical%20Inst&state=pa&page=1&facility_code=249B0438

ericks24 commented 8 years ago

@saintsoup52 Clicking on the link you provided takes me to the school page just fine. If you search for school by typing in full name....still get above message i captured at top.

saintsoup52 commented 8 years ago

@ericks24 That is because you are typing "ITT Tech Institute-Pittsburgh" vs ""ITT Technical Institute-Pittsburgh"

You have to spell out "technical'

ericks24 commented 8 years ago

@saintsoup52 I am spelling it out. I was spelling it out to begin with didn't realized i put Tech instead of Technical on title of this issue. On CT now and still getting message

saintsoup52 commented 8 years ago

@ericks24 there is no space before the hyphen:

image

ericks24 commented 8 years ago

All of that comes up just fine. When i click on school still get message. 3 other ppl getting the same message when they click on school

saintsoup52 commented 8 years ago

@mphprogrammer

I see what you are talking about now... I am getting the same error message...

Are we not purging the the school search list? Or are we not pulling the data correctly?

mphprogrammer commented 8 years ago

I think I see an issue with the css - tell me if the same problem happens with ITT TECHNICAL INSTITUTE-LEVITTOWN, ITT TECHNICAL INSTITUTE-PHILADELPHIA and even ITHACA POLICE DEPARTMENT

On Mar 3, 2016, at 8:02 AM, Patrick Campbell notifications@github.com wrote:

@mphprogrammer https://github.com/mphprogrammer I see what you are talking about now... I am getting the same error message...

Are we not purging the the school search list? Or are we not pulling the data correctly?

— Reply to this email directly or view it on GitHub https://github.com/department-of-veterans-affairs/gi-bill-comparison-tool/issues/326#issuecomment-191752508.

mphprogrammer commented 8 years ago

Sorry it should say xls not css darned spell check.

On Mar 3, 2016, at 9:13 AM, Marc Harbatkin marc.harbatkin.va@gmail.com wrote:

I think I see an issue with the css - tell me if the same problem happens with ITT TECHNICAL INSTITUTE-LEVITTOWN, ITT TECHNICAL INSTITUTE-PHILADELPHIA and even ITHACA POLICE DEPARTMENT

On Mar 3, 2016, at 8:02 AM, Patrick Campbell <notifications@github.com mailto:notifications@github.com> wrote:

@mphprogrammer https://github.com/mphprogrammer I see what you are talking about now... I am getting the same error message...

Are we not purging the the school search list? Or are we not pulling the data correctly?

— Reply to this email directly or view it on GitHub https://github.com/department-of-veterans-affairs/gi-bill-comparison-tool/issues/326#issuecomment-191752508.

mphprogrammer commented 8 years ago

Whenever I get the CT Data file in xls, I open it up in excel and save as a csv. What you see below is a sample of that result. If you take a peek at the Facility Codes (1st column of data) you'll see some that are left-aligned and some are right aligned. The ones that are left-aligned (Such as ITT Tech in Pittsburgh) will not work. There is something in the left aligned facility codes that carries over when its made into a csv. Since the left-aligned facility codes have letters in them they are treated as numbers, the opposite is true for the right-aligned facility codes - they are treated as numbers.

screen shot 2016-03-03 at 9 16 37 am

mphprogrammer commented 8 years ago

ITT Tech in Pittsburg (Levittown, Philadelphia, ...) work fine when you do a partial name match to bring up the search page - because that search does not use the facility code.

mphprogrammer commented 8 years ago

It seems that all the facility codes excel treats as pure numbers (1234567890) because they don't have any letters in them work fine, but the fac codes with letters do not work. Hence the alignment difference.

mphprogrammer commented 8 years ago

Got the problem - autocomplete is comparing codes in the wrong case when using facility codes. If they are numbers that won't be an issue. but if there is text in them it will not match.

SteffieP commented 8 years ago

Marc you are awesome! ☺

From: Marc Harbatkin [mailto:notifications@github.com] Sent: Thursday, March 03, 2016 9:49 AM To: department-of-veterans-affairs/gi-bill-comparison-tool Subject: [EXTERNAL] Re: [gi-bill-comparison-tool] ITT Tech Institute-Pittsburgh (249B0438) (#326)

Got the problem - autocomplete is comparing codes in the wrong case when using facility codes. If they are numbers that won't be an issue. but if there is text in them it will not match.

— Reply to this email directly or view it on GitHubhttps://github.com/department-of-veterans-affairs/gi-bill-comparison-tool/issues/326#issuecomment-191796915.

mphprogrammer commented 8 years ago

Fixed - should go up today.