search

department-of-veterans-affairs / next-build

Front-end templating, build, and deploy for VA.gov CMS content.
Creative Commons Zero v1.0 Universal
9 stars 5 forks source link

Fix README typos, remove next-specific data attributes for components #801

Closed randimays closed 2 weeks ago

randimays commented 1 month ago

Description

Removes data-next-component attributes from components that have them as we won't be needing this data in the markup. This also includes updates to the design system breakpoints that have been done in content-build and vets-website. Some of this code predates those changes so I applied them in this PR. There should be no functionality changes; it's only a name change.

Ticket

Relates to https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19386

Developer Task

- [x] PR submitted against the `main` branch of `next-build`.
- [x] Link to the issue that this PR addresses (if applicable).
- [x] Define all changes in your PR and note any changes that could potentially be breaking changes.
- [x] Alerted the #accelerated-publishing Slack channel to request a PR review.
- [x] You understand that once approved, you are responsible for merging your changes into `main`. (Note that changes to `main` will move automatically into production.)
eselkin commented 1 month ago

@randimays Should the package.json be brought up to what it is in vets-website if using the current breakpoints stuff?

    "@department-of-veterans-affairs/component-library": "^47.2.0",
    "@department-of-veterans-affairs/css-library": "^0.12.2",
    "@department-of-veterans-affairs/formation": "11.0.26",

Or were they functional in the current ones?

randimays commented 1 month ago

@eselkin Great callout. I just double checked and they both work, but notably the now-deprecated version isn't applying correctly so we are benefiting from this either way. Screenshots below were taken at 1201px browser width, which is the DST breakpoint for large-screen / desktop-lg

Before

Screenshot 2024-10-29 at 2 55 15 PM Screenshot 2024-10-29 at 2 59 21 PM

After

Screenshot 2024-10-29 at 2 55 27 PM Screenshot 2024-10-29 at 2 59 31 PM
randimays commented 4 weeks ago

@timcosgrove Updated the changes to remove the data-next-components instead; I agree that we can rely on browser extensions to identify components and this will just clutter the markup 👍🏻 This is ready for your review again

randimays commented 3 weeks ago

@timcosgrove Bumping for your review when you get a chance please!

randimays commented 2 weeks ago

@timcosgrove Bumping for your review please :)