department-of-veterans-affairs / notification-api

Notification API
MIT License
16 stars 9 forks source link

HOTFIX - Updated Missing Sid Log to Warning #1991

Closed k-macmillan closed 1 month ago

k-macmillan commented 2 months ago

Description

This is related to #790 and #2019 , but does not resolve the issue. This is a workaround to log as a warning instead of as an error, so we can clean up the log error clutter.

Attempted to remove the VETEXT_SID variable from dev but it fails regression, and rightly so. Will talk with QA about regression and this particular issue in the future.

issue #790

How Has This Been Tested?

Unit test updated to make sure it tries to call the logger and that the values it passed were the expected values. Deployed, had no issues. Removed the VETEXT_SID from dev so it matches Prod and deployed, logs correctly.

image

Checklist