department-of-veterans-affairs / notification-api

Notification API
MIT License
16 stars 9 forks source link

Method to Generate Signature Based on Params and API Key #2001

Closed k-macmillan closed 1 month ago

k-macmillan commented 2 months ago

User Story - Business Need

We wish to enhance ENP by allowing a callback URL to be specified when a request is made to VA Notify's sms/email paths. We will generate a signature based on the parameters being sent to our client (Service). Adding that signature to the request is part of a separate ticket, this ticket is to create the generate_callback_signature method.

User Story(ies)

As a VA Service authorized to send notifications I want to specify a callback url other than the service-level callback So that we have more agency when deciding how to handle callbacks

Additional Info and Resources

Acceptance Criteria

QA Considerations

Potential Dependencies

npmartin-oddball commented 2 months ago

Hey team! Please add your planning poker estimate with Zenhub @coreycarvalho @cris-oddball @EvanParish @k-macmillan @kalbfled @MackHalliday @mchlwellman

k-macmillan commented 1 month ago

Realized that a Notification or notification_id is unnecessary. The signature itself does not care about that, it just takes data and signs it.

k-macmillan commented 1 month ago

PR merged. Updated slides.