Closed k-macmillan closed 1 month ago
Hey team! Please add your planning poker estimate with Zenhub @coreycarvalho @cris-oddball @EvanParish @k-macmillan @kalbfled @MackHalliday @mchlwellman
Realized that a Notification or notification_id is unnecessary. The signature itself does not care about that, it just takes data and signs it.
PR merged. Updated slides.
User Story - Business Need
We wish to enhance ENP by allowing a callback URL to be specified when a request is made to VA Notify's sms/email paths. We will generate a signature based on the parameters being sent to our client (Service). Adding that signature to the request is part of a separate ticket, this ticket is to create the
generate_callback_signature
method.User Story(ies)
As a VA Service authorized to send notifications I want to specify a callback url other than the service-level callback So that we have more agency when deciding how to handle callbacks
Additional Info and Resources
Acceptance Criteria
generate_callback_signature
method takes: ~notification
~api_key_id
andcallback_params
generate_callback_signature
is a 64 character, url-safe string (use hexdigest, not digest)api_key_id
that was passed in)hmac.Hash(b'key', b'data', digestmod=hashlib.sha256)
QA Considerations
Potential Dependencies