department-of-veterans-affairs / notification-api

Notification API
MIT License
16 stars 9 forks source link

#2040 Search NotificationHistory for GA4 #2042

Closed kalbfled closed 1 month ago

kalbfled commented 1 month ago

Description

When veterans open an e-mail notification, a GET request gets made that kicks off a Celery task that looks up a notification in the "notifications" table. However, the notification might have moved to the "notification_history" table. The changes search the latter table if the notification isn't found in the former table.

I also changed a logging statement from "error" to "warning". A veteran might open a message after the notification is purged from history, and that is not an error.

issue #2040

How Has This Been Tested?

I wrote a new unit test.

Checklist