department-of-veterans-affairs / notification-api

Notification API
MIT License
16 stars 9 forks source link

HOTFIX - Added Log Statement For Expected Missing Twilio Body #2077

Closed k-macmillan closed 1 month ago

k-macmillan commented 1 month ago

Description

We recently had a series of warnings due to incoming messages from Twilio that did not contain a body. They didn't have a body because the message type did not have one. We merely forward those messages but the group we forward to was not able to handle the missing Body field.

Redacted sensitive information, added a log statement, and abort that particular record.

issue N/A

How Has This Been Tested?

New unit test made. Built a new custom message just for this case where the Twilio "Body" field does not exist. Existing tests pass. Deployed.

Checklist