department-of-veterans-affairs / va-forms-system-core

VA Forms System Core will be a React library hosted in NPM that will allow engineers and designers to easily interact with Forms inside of vets-website.
https://department-of-veterans-affairs.github.io/va-forms-system-core/
6 stars 4 forks source link

fix(#547): Ensure that no duplicate IDs are found on the review page #565

Closed obliviga closed 2 years ago

obliviga commented 2 years ago

Description

Ensures that no duplicate IDs are found on the review page. Ensures that the Edit link on the review page has an adequate aria-label attribute, so that screen reader users know what they are about to edit. Also ensure that focus is set on the appropriate Edit link when the user activates the Back To Review Page button, so they put back to the place that initiated the edit view.

Original issue(s)

https://github.com/department-of-veterans-affairs/va-forms-system-core/issues/547

Testing done

Yes

Screenshots

https://user-images.githubusercontent.com/5934582/185257142-3f64f6e0-f5b1-4955-88ed-7cd28d39c495.mov

Definition of done

va-vsp-bot commented 2 years ago

:tada: This PR is included in version 1.3.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: