search

department-of-veterans-affairs / va-mobile-app

"If VA were a company, it would have a flagship mobile app."
https://department-of-veterans-affairs.github.io/va-mobile-app/
17 stars 2 forks source link

Automation - Add status checks for App Store Requirements #9228

Open narin opened 3 months ago

narin commented 3 months ago

Automation Ticket

Type of Change

What systems/scripts are changing?

What is the work being done?

Both app stores have certain requirements that would cause our builds to fail if not met. We can add a status check to check these requirements and prevent PRs from being merged if unmet. Some of the requirements are documented here but we should confirm the requirements in official Apple/Google docs.

  1. App Store and Google Play maximum screenshots
  2. What's New/App Description character limit

Acceptability Criteria

Add a status check when there are changes to the fastlane folders to check:

lexicalninja commented 1 week ago

@timwright12 you still want these checks in the CI?

timwright12 commented 1 week ago

yeah, anything we can do to avoid a store rejected

lexicalninja commented 3 days ago

@timwright12 Can you or someone else get me the character limits for the descriptions and whats new content?

lexicalninja commented 3 days ago

I need apple description and release notes char limits i need google full description, short description, and whats new limits

timwright12 commented 3 days ago

iOS Character Limits

Description: 4000 "What's new in this version": 4000 Keywords: 100

Android Character Limits

Release notes: 500 Release name: 50 Short description: 80 Full description: 4000

lexicalninja commented 2 days ago

@timwright12 do you want these to be required checks when these are updated or just status checks that dont prevent merging?

timwright12 commented 2 days ago

Noting that we caught up in zoom about this. They will be status checks and also run on merge to develop where they can alert slack if something slips through the cracks