department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
0 stars 0 forks source link

Link component - Add support for link to add to calendar #169

Open TimRoe opened 4 months ago

TimRoe commented 4 months ago

Description

Split from #118 to add support for Link variant to add an event (e.g. an appointment) to a user's calendar. Basic setup for this variant is already in place, but it was unclear how or if it's possible to embed a native module within a package since it entails Kotlin/Swift code to handle the native module and may need special handling at app build time to do so (potentially in different ways for Expo projects vs CLI native projects).

Acceptance Criteria

- [ ] Explore ability to handle react native bridge dependent components within the package and, if possible, add it - [ ] If AC1 proves not possible, clean up code from #118 relating to the calendar (including in `Link.tsx`, stories file, `OSfunctions.tsx`, and `RNCalendar.kt`) - In this scenario, we should still support the assistance in visually setting Calendar, but it should require onPress logic to handle the processing which is defined at the app-level - [ ] Update Android functionality to work similarly to iOS. Ideally, when someone clicks on the "Add to calendar" link, a panel will open within the app where they can add the event to their calendar without leaving the app (like in iOS). If this is not possible, reach out to Jessica.
narin commented 4 months ago

Adding native calendar functionality would require substantial changes to the codebase. Created a new ticket #192 for higher-level discovery of whether native functionality should be in scope of our component library. Moving this to the Blocked column.

narin commented 4 months ago

Previous native calendar code was removed in PR https://github.com/department-of-veterans-affairs/va-mobile-library/pull/205. Reference this PR if we decide that we want to handle custom native functionality.