department-of-veterans-affairs / va-mobile-library

https://department-of-veterans-affairs.github.io/va-mobile-library/
ISC License
0 stars 0 forks source link

[Feature] Add Analytics pass through events to Link #205

Closed narin closed 4 months ago

narin commented 4 months ago

Description of Change

Screenshots/Video

iOS

https://github.com/department-of-veterans-affairs/va-mobile-library/assets/786704/bc1850a7-a7be-4504-a2c8-ca91f18fb6e6

Android

https://github.com/department-of-veterans-affairs/va-mobile-library/assets/786704/4b558b18-5509-4fa4-95eb-053a88e80a3f

Web (custom link only)

https://github.com/department-of-veterans-affairs/va-mobile-library/assets/786704/59bb3393-3b91-43c8-85da-2225e6c2d8e5

Testing

PR Checklist

Code reviewer validation:

Publish

If changes warrant a new version per the versioning guidelines and the PR is approved and ready to merge:

TimRoe commented 4 months ago

Remove native calendar code

Should also remove the RNCalendar.kt and folder in utils for this.

TimRoe commented 4 months ago

Also dropping a comment to indicate I think we can continue ignoring publishing a Link package as there's still MVP-outstanding tickets like the a11y for inline and adding attachments.