Open dsasser opened 1 year ago
FYI @wesrowe
@dsasser, re the CTA component we didn't use – is it documented in the design system? I didn't see it on a search. Action Link is a flavor of link in the design system though, we've used it several places.
@dsasser, re the CTA component we didn't use – is it documented in the design system? I didn't see it on a search. Action Link is a flavor of link in the design system though, we've used it several places.
It isn't a design system component, but a React component, and therefore isn't found in the Design System. It is found in the vets-website repository only.
Just yesterday it clicked for me: "react components" are being generally deprecated because they hold the site back from adopting US Web Design System 3.0. React components are being replaced by web components. So I think this ticket would move us in the wrong direction. Does that track for you, @dsasser?
Just yesterday it clicked for me: "react components" are being generally deprecated because they hold the site back from adopting US Web Design System 3.0. React components are being replaced by web components. So I think this ticket would move us in the wrong direction. Does that track for you, @dsasser?
Yeah this is a tricky subject, but no that doesn't track for me. Deprecating all React components in vets-website isn't possible. React components are just reusable javascript functions written in React. I think what you are referring to is the eventual deprecation of all React components within the design system itself, which does impact vets-website wherever those components are utilized. For instance the RadioButtons React component within the design system was recently deprecated, and it meant that we needed to upgrade the vets-website React components that utilized the RadioButtons design system component.
In this case, the CTA component I'm referring to is a vets-website owned React component that utilizes design system components to render content on the screen.
Thanks for the clarification. That helps. In the future maybe we need to be clearer about "Design system react components" versus... I guess "react components" just how you used it. :)
Description
In #12591 we implemented the BTSSS react widget using the web component. However, an existing CTA component exists in vets-website that could possibly be leveraged to reduce tech debt on the BTSSS widget.
The CTA component was not utilized for the following 2 reasons:
Engineering notes
The CTA widget is located here.
Tasks
Acceptance Criteria
Team
Please check the team(s) that will do this work.
CMS Team
Public Websites
Facilities
User support