Update Download PDF link on Form detail pages to <button> element

[laflannery]

Status

[2024-08-19] [Fran] Blocked by the linked Spike.

Description

We recently removed the find_forms_show_pdf_modal flipper so that now we always show the modal when the user clicks to Download the PDF on the Find forms search results. When this was done, the element for "Download PDF" was switched to a <button> because it now activates the modal consistently.

This element is also present on the forms detail page but is currently still an <a> tag. For consistency should also change this to the same <button> behavior as on the search results:

Acceptance Criteria

• [ ] When a user clicks to Download the PDF The Forms Detail page, the same behavior as on the search results occurs.

[FranECross]

Fran to create Spike ticket to refresh our memories on what's happening. Daniel might have some background on this.

[laflannery]

There is an epic specifically to get the listing and detail behavior of this modal experience the same, this ticket would probably belong in that epic because that's ultimately all I'm asking for here - update the detail page to match the new behavior that's now on the listing