Closed thejordanwood closed 3 months ago
Pulled in but ack that it might not close in Sprint 4 due to Typography phase 2.
I started a design for this in the Vet Centers Figma file and am going to work on getting reviews.
notes from UX sync:
Here's my pre-OOO update. I've been doing this work in the Vet Centers Figma file.
What I've done since UX sync:
Next steps for this:
Adding @omahane and @eselkin as assignees for awareness about eng review needed during Sprint 5.
@aklausmeier @thejordanwood Please include consideration for how locations are sorted and displayed. We're getting reports that the list for MVCs may have regressed recently. The sort order should prioritize those locations which are actually affiliated with the parent Vet Center, followed by an alphabetized list of those which were added as "additional" or "nearby".
Reference: #18229 Sort order for Vet Center Satellite locations
reviewed design and left comments in Figma for Jordan
@thejordanwood documented accessibility improvements from Laura's previous Vet Center audit in the Figma file, don't want to lose sight of these insights
Update on the work that's been done to this recently. I thought this might be helpful for those going to the onsite next week, since you'll have limited availability for reviews at that time. @mmiddaugh @aklausmeier @davidmpickett
Feedback I've implemented:
Next steps for this:
For satellite locations, I guess my questions are for @omahane
Will CMS make it possible to query things like prepare_for_your_visit
and field_health_services
from the satellite facility (like some reverse query on a main location or maybe something less complex)? Or are satellites getting their own values/connections for these fields? Provided we can get that data on a query about the satellite facilities, these things seem ok and the design seems good.
End of sprint update:
cc: @jilladams @Agile6MSkinner
TL;DR: I don't see any red flags.
I looked at this yesterday. I don't see anything that breaks what we do in Drupal or will require fundamental restructuring of the code (as far as I can tell). It follows patterns we already have in place and we've even done some code to identify the facility types that don't get their own pages yet, meaning that removing them from that group can be accomplished relatively easily from the Drupal side.
I have the feeling that the menuing and breadcrumbs may be some work, or at least I want to spike on that before taking up that work.
For satellite locations, I guess my questions are for @omahane
Will CMS make it possible to query things like
prepare_for_your_visit
andfield_health_services
from the satellite facility (like some reverse query on a main location or maybe something less complex)? Or are satellites getting their own values/connections for these fields? Provided we can get that data on a query about the satellite facilities, these things seem ok and the design seems good.
They will likely be getting their own values for those fields. I haven't done the content model yet, but that is the most logical path. Alternatively, If we want to surface content from the main location on the satellite pages, I'll account for that in #17695.
Closing per scrum discussions.
Edited link to figma designs to point directly to the correct element.
Description
For Vet Centers 2.0, explore how Vet Center satellite locations could be discoverable in their own right. Notes in a previous ticket state, "Because they appear on the Locations page of the parent Vet Center, they aren't findable in their own right. Veterans do not know to search for these locations in the context of a main Vet Center." (Ticket #17693)
For more context: In the research synthesis, past research indicates that Veterans understand “Satellite locations” as related to the main location and that they are often smaller.
Design
Vet Center Figma file
Design considerations
Acceptance criteria