department-of-veterans-affairs / va.gov-cms

Editor-centered management for Veteran-centered content.
https://prod.cms.va.gov
GNU General Public License v2.0
99 stars 69 forks source link

Update table on sitewide products to use v3 component #18843

Closed laflannery closed 1 month ago

laflannery commented 3 months ago

Description

When we were doing the massive DS component upgrades earlier this year the table component did not have a v3 equivalent, it does now. We need to update everywhere we are using the current table component.

Where are we using table?

Additional context

Acceptance Criteria

randimays commented 1 month ago

Pulling in as stretch for sprint 13.

randimays commented 1 month ago

Currently in production (with v1 tables), we lose some critical contextual information on smaller screens because the headers disappear.

400px

768px

1000px

Unfortunately upgrading to v3 bordered tables, this problem still exists:

400px

768px

1000px

I created a defect in the DST backlog to address this issue: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/3327

They initially suggested we set the stacked property in the table to false, but:

1) this doesn't make the headers stick throughout breakpoints 2) in some cases, the table will need to be horizontally scrolled which is not ideal 3) content is dynamic and if we set the stacked property we're setting it for every table without knowing whether it's the right solution

Slack thread with DST: https://dsva.slack.com/archives/C01DBGX4P45/p1727883538474889

Given that this is currently an issue in production, I still plan to release the changes to the tables to production with the expectation that this will eventually be addressed by the defect ticket I created, but @FranECross @jilladams holler if you disagree.

jilladams commented 1 month ago

I have no horse in the race and defer to @FranECross and @thejordanwood on UX grounds

FranECross commented 1 month ago

@randimays I agree with releasing to prod. Thanks for ticketing the DST defect!

thejordanwood commented 1 month ago

@randimays Releasing to prod is also fine with me.

randimays commented 1 month ago

Successfully validated in production. Closing as complete.