Refactor SubmitController

[f1337]

Work Planned

Refactor into a fully controlled component.

Should fix UNSAFE_componentWillReceiveProps?

Success Criteria

"We didn't break anything":

• [ ] Improved automated test(s): thoroughness (of use/edge-cases) is more important than line coverage
• [ ] PR created
• [ ] PR reviewed (tag @cvalarida as a PR reviewer)
• [ ] PR merged
• [ ] Smoke-tested on staging (verification steps)
• [ ] Review staging analytics (verify previous weeks to analyze trends)
• [ ] Pre-flight check: If issue, triage and assert roll forward/roll back.
• [ ] Prod deployment
• [ ] Smoke-tested on prod (verification steps)
• [ ] Review production analytics (verify daily over next few days)

Risk Estimate

Scale: 1 (low) – 3 (high)

Risk: 1

<provide an explanation for @meganhkelley to share with broader team>

[meganhkelley]

@f1337 @Clark-W-Griswold this work has been completed, correct? Can you please confirm & close as applicable?

[k80bowman]

The UNSAFE_componentWillReceiveProps is still present

[caw310]

Closing as this is old there is a team focused on building forms and updating the forms library. If this is still an issue, file a new bug for the forms team.