department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
285 stars 206 forks source link

Discovery: Replace local mock utility with MSW #40227

Open timwright12 opened 2 years ago

timwright12 commented 2 years ago

This is a discovery task to replace the platform utility for mocking API requests with msw to offload that maintenance from the platform team and standardize the way we mock API calls within unit tests

There is a platform utility being used right now to mock API calls (mockFetch), which is used about 84 times.

Currently 15 instances of app teams using MSW already in vets-website.

Between platform helpers and MSW there are some duplicative features and we should merge that into a single point of reference.

We want teams to be mocking API calls in unit tests to promote stability in the system so it would be good to standardize around a single tool.

References

Definition of Done

powellkerry commented 1 year ago

Discovery notes: https://vfs.atlassian.net/wiki/spaces/FEC/pages/2526675974/Replace+local+mock+utility+with+MSW

JoeTice commented 1 year ago

Sprint 20 Status Update: In Progress, work started but not able to be completed in a single sprint with other MVP-focused work as priority.

JoeTice commented 1 year ago

Sprint 21 Status Update - No progress on this, based on project work that took priority - removing from sprint plan until we are able to resolve blocking issues on priority work

JoeTice commented 1 year ago

Sprint 22 Update - This task was started after we finished the FE Image Creation blocker, task is in progress but has not been finished yet. Ticket will remain assigned to Kerry as he transitions to DST.

@powellkerry - Please provide an update of where this stands currently.