department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

[FE/BE/Data] 10-10EZR - Discovery: Figure out cause of DoB schema error #77562

Open alexseelig opened 9 months ago

alexseelig commented 9 months ago

As a Veteran, I would like to be able to submit changes in the online EZR and have them save so that I can make sure my information is up to date and so that I don't have to redo it.

luis-simauchi commented 8 months ago

DD log: https://vagov.ddog-gov.com/apm/traces?query=%40_top_level%3A1%20env%3A%2A%20AND%20env%3Aeks-prod%20resource_name%3A%22V0%3A%3AForm1010EzrsController%23create%22%20&cols=service%2Cresource_name%2C%40duration%2C%40http.method%2C%40http.status_code%2C%40_span.count%2C%40_duration.by_service&fromUser=true&graphType=flamegraph&historicalData=true&query_translation_version=v0&saved-view-id=1550&shouldShowLegend=true&sort=time&spanType=service-entry&spanViewType=metadata&traceQuery=&view=spans&viz=stream&start=1709361000000&end=1709363160000&paused=true

luis-simauchi commented 8 months ago

sentry log: http://sentry.vfs.va.gov/organizations/vsp/issues/245028/events/f1e3fc3007f14c97a2aaefe88e59e947/?environment=production&project=3&query=is%3Aunresolved+ezr&statsPeriod=7d

JoshingYou1 commented 8 months ago

According to a member of the identity team, DOB is not a required field in the database. In addition, there are instances of DOB values that are not in the standard dd/mm/yyyy format. Link to the thread: https://dsva.slack.com/archives/CSFV4QTKN/p1710526758238999

emily-brown34 commented 8 months ago

waiting to hear back from the identity team then work with luis

JoshingYou1 commented 8 months ago

Heard back from the identity team. They were able to fetch the record in question. It turns out, the user's DOB is correctly formatted (dd/mm/yyyy). On the backend, we validate the data coming in against the schema right after parsing the form. In other words, we don't modify the DOB, so something must've happened on the frontend. I think we're at an impasse for now. Considering we can't repro the issue, it would be hard to definitively say what caused the DOB to be absent from the payload.

JoshingYou1 commented 8 months ago

Moved to the icebox until this error arises again.

alexseelig commented 8 months ago

@JoshingYou1 couple of quick things:

  1. Did you talk to the EZ team about this?
  2. I have a story for how we handle a user not having a correctly formatted DoB that we'll bring into probably next sprint about how we want to handle it when DoB is formatted correctly. It's a team discovery story to discuss how to handle this holistically. #78792
JoshingYou1 commented 8 months ago
  1. No, I did not. In terms of authenticating and pulling data via MPI, both forms use the same process.
  2. The issue is, the DOB was formatted correctly. A member of the identity team sent me the data from the DB query. We still don't know how an improperly formatted DOB will affect a submission.
alexseelig commented 8 months ago
  1. Understood, I'm just thinking they may have seen this or something similar before, and might have some insights.
  2. Right, that story does not address this particular issue, but it will hopefully help us get out in front of when an unformatted DoB does come our way.