FE | Military Information | incorporate periodOfServiceTypeText into military info page

[mtcA6]

Background

One of the recommendations from our research that we can safely move forward with is incorporating periodOfServiceTypeText

We should be able to use one of the military information figma files (maybe the one we tested with) to display the "active duty" "inactive reserves" etc

Depends on

• https://github.com/department-of-veterans-affairs/va.gov-team/issues/83780

Tasks

• [x] confirm which treatment of the myriad we have is the best

Acceptance Criteria

• [ ] the military information page has the period of service type text

[mtcA6]

@adamwhitlock1 could you point this?

Chatted with Chante and she thinks we should move forward with this update and then we could close out the military history epic and if/when the IES ILER stuff resurfaces we can create a new epic and a track that work separately.

cc: @ACParker89

[adamwhitlock1]

I think we will need to discuss this further before I can point it.

The periodOfServiceTypeText does not exist within the current service history response that we have in production, and I think that came from the military service profile endpoint that Tom had used to get the expanded info.

We only have this information available on each service history entry currently:

{
  branchOfService: 'Ait Force',
  beginDate: '2009-04-12',
  endDate: '2013-04-11',
  personnelCategoryTypeCode: 'V',
  characterOfDischargeCode: 'A',
}

[mtcA6]

@adamwhitlock1 Are you suggesting we need a BE ticket here as well?

I thought Tom's new endpoint was in production. We can chat about it on planning.

[mtcA6]

@adamwhitlock1 you able to toss some points on here?

[tpharrison]

@adamwhitlock1

A period service type will show on a service episode, but not on an academy episode (the fields will be null).

Here are the period service type values for reference...

Code	Text
A	Active duty member
B	Presidential Appointees of all Federal Government agencies
C	DoD and Uniformed Service civil service employee, except Presidential appointee
D	Disabled American veteran
E	DoD and Uniformed Service contract employee
F	Former member (Reserve service, discharged from RR or SR following notification of retirement eligibility)
H	Medal of Honor recipient
I	Non-DoD civil service employee, except Presidential appointee
J	Academy student
K	Non-appropriated fund DoD and Uniformed Service employee (NAF)
L	Lighthouse service
M	Non-federal Agency civilian associates
N	National Guard member
O	Non-DoD contract employee
Q	Reserve retiree not yet eligible for retired pay ("Grey Area Retiree")
R	Retired military member eligible for retired pay
T	Foreign military member
U	DoD OCONUS Hires
V	Reserve member
W	DoD Beneficiary, a person who receives benefits from the DoD based on prior association, condition or authorization, an example is a former spouse
Y	Service affiliates
DVN	DoD provided a NULL or blank value
DVU	DoD provided a value not in the reference table
CVI	Value is calculated but created an invalid value
VNA	Value is not applicable for this record type

[ACParker89]

Display Codes A,V,N on FE as per conversation on 6/13 @adamwhitlock1 @mtcA6

[mtcA6]

@tpharrison @adamwhitlock1 weird there isn't an "inactive" do we have the right field selected?

[mtcA6]

should we use the military service episodes instead?

[tpharrison]

We are using military service episodes, but I'll look into it.

[mtcA6]

Chatted w/tom I think this is okay as we discussed today, he talked me through the details and showed me the vadir tables

[adamwhitlock1]

@mtcA6 We can validate this now with user 226 in staging, and will see active duty member as their periodOfServiceTypeText

[mtcA6]