Closed marywang2 closed 4 months ago
Work is done in this PR. Waiting on:
@syd-hoeper @marywang2 one issue to discuss: The design system v3 file upload (the drag & drop one) only supports a single file upload at this time. I've gone ahead and replaced that file upload with the v1 version (identical to 10-10d and our other forms) as it supports multiple file uploads, but I wanted to bring it to your attention.
All those changes sound good to me!
For transparency: Michael and I discussed the List and Loop changes in Figma last week and everything seems good to go. Noting that the Figma will be out-of-date and I can update that once we get to the UAT stage.
I'm having trouble getting on staging right now, so I'm not able to see the "Do you have another?" typography issue, but everything else I sign off on from a designer perspective
Thanks! Typography issue:
Thanks Michael! Okay yeah that's not the worst thing in the world, so I 'd say it's fine for now.
Also update on the multiple file uploads is that I asked the DS team and they said that there actually is a multiple file version, it's just in Storybook: https://design.va.gov/storybook/?path=/docs/uswds-va-file-input-multiple--docs
Ok I'm going to update the file upload to be V3 and will follow up here after - thanks!
After looking into it more, seems like this multi-file component hasn't really been used in other form-library forms yet, so I'll have to spend a bit of extra time getting it integrated. I'll keep updates here as this progresses, but it'll extend the time needed for this ticket a bit
upped the points because of file upload stuff - still digging into the best way to implement the new version
At this point, there appears to be a bug in the v3 upload component that will have to be resolved by platform (waiting to hear back on Monday for confirmation).
The bug prevents files from actually being deleted after they've been uploaded, so users wanting to remove a file before submitting their form can't actually do that.
@syd-hoeper @marywang2 for awareness - If the above is confirmed, I think we should split the specific implementation of the v3 file component into a separate ticket, put it on the backlog, and proceed with the v1 file component for the time being/evaluate this work. Would that be acceptable?
Per the above comment, I've created this ticket for the move to the v3 file upload component (when the bug is fixed). I'm going to move this ticket to review now since everything is in place with the v1 file upload.
@marywang2 @syd-hoeper This should be visible on staging at this point and is ready for review. Thanks!
@michaelclement - some changes below. Please also double check the dynamic language that is pulling in for 'your' vs 'beneficiary name' vs 'the beneficiary' (that it is pulling in the right one and is also the correct case - seeing a bunch of upper case for some reason). cc @syd-hoeper for awareness.
Changes:
claim - eob upload page (filing for self): https://staging.va.gov/family-and-caregiver-benefits/health-and-disability/file-champva-claim-10-7959a/eob-upload
medical claim file upload screen: I think this is missing. I didn't see it, only the EOB screen.
Yeah I'm also not seeing the medical upload page, just the EOB pages. Agree with everything Mary said above. All the upload stuff looks good to me
Requested copy changes have been implemented in this PR (see PR for screenshots of changes)
Waiting on
@syd-hoeper @marywang2 re: the page not showing up, I'm able to see it on staging... Not sure if it's possible y'all are not seeing the latest changes somehow? But regardless, maybe after this next PR goes through we can check again and double-verify. Here's what I'm seeing:
Latest changes have been merged in, are y'all able to see the page yet? @marywang2 @syd-hoeper
I can see it now!
I see it now too! Thanks @michaelclement!
As a VA.gov user, I want to fill out the CHAMPVA claim form with my claim information so that I can get reimbursed.
Figma link-> Updated July 5th Figma LinkClaim information:
Acceptance criteria: