department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 201 forks source link

Staging Review finding: Icon on map image not actually a button, not focusable. #87426

Open shiragoodman opened 2 months ago

shiragoodman commented 2 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Sitewide Facilities Product: VBA Regional Offices Feature: Site Modernization

Findings details

VA.gov Experience Standard - issue: User experiences an unexpected interaction with a component or pattern. VA.gov Experience Standard - category: Usability Launch-blocking: No Design System review: No Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

In the "Location and contact information" section, the image of a map has a zoom_out_map icon overlayed on top of it, styled to look like a button (including hover state). However:

This doesn't match with user expectations (clicking does something unexpected), and might frustrate keyboard-only users who may believe there's some additional functionality that they can't get to.

Recommended action

I would recommend harmonizing with ongoing work for the Vet Centers template, which recommends removing the icon. I don't think it adds much value here.

References


Next Steps for the VFS Team

jilladams commented 1 month ago

Tracking in https://github.com/department-of-veterans-affairs/va.gov-cms/issues/18268