department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

[CST] Add design for second type of 5103 Notice request so that we can fully remove "Ask for your claim decision" banner #88338

Closed skylerschain closed 1 month ago

skylerschain commented 1 month ago

Value Proposition

As a veteran with a 5103 standard notice, I want to be able to find the place in CST where I can submit a waiver, so that I can hopefully get my claim decided faster if I have no evidence to submit.

Background Context

As @jerekshoe pointed out here, the 5103 Notice Response request is treated differently in CST than the Automated 5103 Notice Response request.

The Custom 5103 shows up as Automated 5103 Notice Response and our new design will apply to this case. But Standard 5103 requests don't show up in CST (until the request is closed).

Once a user has gone to the 'Ask VA to Decide' page and clicked the submit button; this will mark evidenceWaiverSubmitted5103 to true. Then someone from the VA will go to VBMS and closes the tracked item. The request will be considered closed and it will show up as a tracked item with a closedDate and a status of NO_LONGER_REQUIRED in the CST.

The Veteran will still get a letter for this request though, so it makes sense to have some alert for this in CST and some way for them to satisfy the tracked item.

Current idea is to use the same FE logic that shows the "Ask for you claim decision" banner on the Files tab to instead show an alert that directs the user to the 5103 detail page.

Open questions

Q: For @jerekshoe: Can we connect this backend logic to a frontend that is the same as the new 5103 design? It wouldn't technically be a 1P request from BGS but we could make it look like one in our frontend (until we can get BGS to change this for us).

Design

FIGMA

STANDARD 5103

Design Tasks

Currently Standard 5103s show the "Ask for your claim decision" banner":

Screenshot 2024-07-15 at 6 15 30 PM

Ideally we would show a message similar to what we will show for Custom 5103:

Screenshot 2024-07-15 at 6 16 27 PM

Enablement team (if needed)

@jstrothman

Engineering Tasks

(Notes from XFN Sync 7/19) Logic and other engineering tasks to hide Standard 5103 alert (AKA blue banner AKA "Ask for your claim decision") when a Custom 5103 ("Automated 5103 Notice Response") is present: Update status tab:

Update files tab:

Create a new component for the Standard 5103 Notice:

Create a new URL:

Add Tests:

Out of scope

Definition of Done

Acceptance Criteria

jacobworrell commented 1 month ago

We don't know exactly where to get a screenshot of the present state, can't duplicate in staging easily.

skylerschain commented 1 month ago

Added design spec to "Design" section above. @pmclaren19 this should be ready to work when you're back. Let me know if you want me to add anything else to the spec.

pmclaren19 commented 1 month ago

@skylerschain lets meet up whenever you have a chance so that we can update the AC to what you have in the design as it looks like the AC does not currently match the new design.

pmclaren19 commented 1 month ago

Met with @skylerschain this morning and discussed the new design. Updated the Engineering tasks and AC to reflect the new design!

pmclaren19 commented 1 month ago

Pulled back into sprint backlog for the new sprint July 31 - Aug 13! Ran into some vets-api issues so having trouble getting my local env to stand up but once that is working again just need to test thing and update some tests!

pmclaren19 commented 1 month ago

@skylerschain @jacobworrell merged into Staging but VBMS is down so unable to create test data to test my changes. Only thing I have access to test so far is Merged to staging and verified the following changes...

Will let you both know when I am able to test further.

pmclaren19 commented 1 month ago

@skylerschain and @jacobworrell was able to test these changes and all looks good! Created claims to test in VBMS on user 19 and found the following when cst_5103_update_enabled = true ...