department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 202 forks source link

Hi. Question about code review for a vets-api PR. We have a ... #94028

Closed platform-support-slack-integration[bot] closed 1 week ago

platform-support-slack-integration[bot] commented 1 week ago

Submitted By: jill.adams Topic: PR Review Team: Tier 1 Support

Hi. Question about code review for a vets-api PR. We have a tech debt removal PR that rips out a lot of dead code that isn't in use in production anymore, and have tested it locally to verify no impact to the product. However: it's big. We are wondering about an exception to the 500 line rule: https://github.com/department-of-veterans-affairs/vets-api/pull/18610

platform-support-slack-integration[bot] commented 1 week ago

Slack Thread Link: https://dsva.slack.com/archives/CBU0KDSB1/p1727803192642279