Submitted By: jill.adams
Topic: PR Review
Team: Tier 1 Support
Hi. Question about code review for a vets-api PR. We have a tech debt removal PR that rips out a lot of dead code that isn't in use in production anymore, and have tested it locally to verify no impact to the product. However: it's big. We are wondering about an exception to the 500 line rule: https://github.com/department-of-veterans-affairs/vets-api/pull/18610
Submitted By: jill.adams Topic: PR Review Team: Tier 1 Support
Hi. Question about code review for a vets-api PR. We have a tech debt removal PR that rips out a lot of dead code that isn't in use in production anymore, and have tested it locally to verify no impact to the product. However: it's big. We are wondering about an exception to the 500 line rule: https://github.com/department-of-veterans-affairs/vets-api/pull/18610