search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
285 stars 206 forks source link

Collaboration Cycle for CMS Team - Next Build and Next Build's Events and Event Listings Templates #96324

Open gracekretschmer-metrostar opened 3 weeks ago

gracekretschmer-metrostar commented 3 weeks ago

VFS product information

VFS team name

CMS Team

Next Build is the application that will replace Content Build to publish content from Drupal CMS into the unauthenticated pages within VA.gov. Next Build’s events and event listing templates are used as structures for editors within Drupal CMS to create and publish events and event listings onto VA.gov. Events and event listing are interconnected content types, so we would recommend reviewing the two templates together. Specifically, if an event is created (example), it is created onto an event listing (example). On VA.gov event listings are called calendars.

Product name

Next Build and Next Build's Events and Event Listing Templates

Known Defects

All known defects for events can be found in the task list in this ticket and all known defects for event listings can be found in the task list of this ticket.

Note, there is one launch blocking issue within the defect list. Here is the ticket for that launch blocking defect and the team will resolve the issue before going into production. This has been resolved - TFC.

Feature name

Events and Event Listing Templates

GitHub label for team

CMS Team

GitHub label for product

Next Build

GitHub label for feature

Next Build

Public DSVA Slack channel for VFS team

accelerated-publishing

Collaboration Cycle touchpoints

Architecture Intent

Toggle Architecture Intent instructions #### Before the meeting ##### VFS team actions - [x] Review [Architecture Intent Guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/architecture-intent) to understand what this touchpoint involves. - [x] Schedule your Architecture Intent (with at least 2 business days lead time from now): - Open the [Calendly Architecture intent calendar](https://calendly.com/collaboration-cycle/architecture-intent) - Select a date and time and click "Confirm" - Add your name and email - Click "Add Guests" and enter the email addresses for VFS team attendees - Click "Schedule Event" - [x] Link all artifacts in the `Architecture Intent artifacts for review` section below at least two business days before the scheduled Architecture Intent. Please don't add artifacts in the comments section. **Architecture Intent artifacts for review** [See guidance on Architecture Intent artifacts.](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/architecture-intent#ArchitectureIntent-Whatartifactswillbeneeded?) Feedback is based on the artifacts provided here as well as information provided during the meeting. Please provide links to artifacts **at least two business days** before the scheduled meeting. Required: - [x] Completed [Architecture Intent Meeting Template](https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/master/platform/engineering/collaboration-cycle/architecture-intent/checklist/cms_team-next_build-11132024.md) - [x] ~~[User data flow diagram](https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/master/platform/practices/zero-silent-failures/how-to-create-a-user-data-flow-diagram.md), if your application accepts data from a user.~~ We do not collect user data of any kind. ##### Platform Team actions - [x] Meeting date/time: **Nov 19 at 1:30pm ET** #### After the meeting ##### Platform Team actions - [ ] Update this ticket with the Zoom recording - Recording link - Passcode: - Engineering feedback - [ ] Feedback ticket attached to milestone - [ ] No feedback - Mobile Engineering feedback - [ ] Feedback ticket attached to milestone - [ ] No feedback - Security feedback - [ ] Feedback ticket attached to milestone - [ ] No feedback ##### VFS team actions - [ ] Review feedback tickets. Comment on the ticket if there are any questions or concerns.

Staging Review

Toggle Staging Review #### Before meeting ##### VFS actions - Navigate to reference link: [Staging Review Guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/staging-review) - [x] Schedule your Staging Review when ready: - Open the [Calendly staging review calendar](https://calendly.com/collaboration-cycle/staging-review) - Select a date and time and click “Confirm” - Add your name and email - Click "Add Guests" and enter the VFS meeting attendees email addresses - Invite all relevant VFS team members, including accessibility support, product owners, and other VA stakeholders - Click "Schedule Event" - [x] If this product contains any [experimental design](https://design.va.gov/experimental-design/), add the `experimental-design` label and schedule a meeting with DSC to present the research findings. - [ ] Link all artifacts **ONLY** in the Staging Review artifacts section below at least four days before the scheduled Staging Review. **Do NOT add artifacts to Comments section** - [x] I confirm the environment is available and test users have been provided. - [x] Please verify your product information in the [Product Directory](https://depo-platform-documentation.scrollhelp.site/getting-started/vfs-product-directory). **Staging Review artifacts** Links to [Staging Review artifacts](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Staging-review.1810137181.html#Stagingreview-Artifacts) must be added to this ticket 4 business days ahead of the scheduled meeting. Please do not make changes to the product or artifacts during the 4-day review period. **Required artifacts** - [x] **URL(s) to review the product** - https://staging.va.gov/outreach-and-events/events/ - https://staging.va.gov/outreach-and-events/events/64661/ - https://staging.va.gov/outreach-and-events/events/73946/ - https://staging.va.gov/pittsburgh-health-care/events/ - https://staging.va.gov/eastern-colorado-health-care/events/ Note, there are no test users needed to access the events and event listing templates. - [ ] **Drupal or Staging URL for updated primary entry point:** the main way Veterans will access the tool through site navigation (not search) - If the primary entry point is not a page on VA.gov, include information about how to view it. Reach out to `@platform-governance-team-members` on Slack with any questions. - [x] **Test users and scenarios** (when applicable) Note, there are no test users needed to access the events and event listing templates. - Make sure all user scenarios can be tested, i.e.: in-progress form, submitted form, new form. - [x] **Link to Sitewide CAIA intake ticket**, if applicable. - [x] **Completed accessibility testing artifact:** [Testing ticket here](https://github.com/department-of-veterans-affairs/va.gov-team/issues/96766) - [x] **QA Artifacts:** artifacts that correspond to each of the [QA Standards](https://depo-platform-documentation.scrollhelp.site/developer-docs/quality-assurance-standards). - [x] Regression test plan The regression and test plan are the same, since the testing has been to do a visual QA to determine if there are any changes between Content Build’s events and event listing templates and Next Build’s events and event listing templates. Next Build is the system that is replacing Content Build. For the regression test plan and test plan, the CMS team has been having SMEs review the templates and following these steps for the visual QA, listed [here](https://dsva.slack.com/docs/T03FECE8V/F07UG7EAWTE). The CMS team QA testing by an accessibility specialists, OCTO POs, and engineers. Their findings were first reported in two spreadsheets ([#1](https://docs.google.com/spreadsheets/d/1czCFV4d4rQXcxoxVYoWtVyfSNGTDChhYchLLsxmp3OY/edit?usp=sharing) and [#2](https://docs.google.com/spreadsheets/d/1pNrZsgDmdckvOndrLzLZhBb7dl1GfZFlXXUR-2NeWj4/edit?usp=sharing)) and, later, we moved to a ticketing system to report defects found during the QA process. All defects found were reported and added to the Defect column of [this board](https://github.com/orgs/department-of-veterans-affairs/projects/1464). - [x] Test plan The regression and test plan are the same, since the testing has been to do a visual QA to determine if there are any changes between Content Build’s events and event listing templates and Next Build’s events and event listing templates. Next Build is the system that is replacing Content Build. For the regression test plan and test plan, the CMS team has been having SMEs review the templates and following these steps for the visual QA, listed [here](https://dsva.slack.com/docs/T03FECE8V/F07UG7EAWTE). The CMS team QA testing by an accessibility specialists, OCTO POs, and engineers. Their findings were first reported in two spreadsheets ([#1](https://docs.google.com/spreadsheets/d/1czCFV4d4rQXcxoxVYoWtVyfSNGTDChhYchLLsxmp3OY/edit?usp=sharing) and [#2](https://docs.google.com/spreadsheets/d/1pNrZsgDmdckvOndrLzLZhBb7dl1GfZFlXXUR-2NeWj4/edit?usp=sharing)) and, later, we moved to a ticketing system to report defects found during the QA process. All defects found were reported and added to the Defect column of [this board](https://github.com/orgs/department-of-veterans-affairs/projects/1464). - [x] Coverage for References This step is not applicable to Next Build’s events and event listing. - [x] Summary (Defects) reports All known defects are listed as tasks under the [Events](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19572) and [Event Listing](https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19573) epics. Note, none of these defects (we believe), fall under the category of launch blocking for the collab cycle. - [x] E2E tests 1. https://github.com/department-of-veterans-affairs/next-build/blob/main/playwright/tests/event.spec.ts 2. https://github.com/department-of-veterans-affairs/next-build/blob/main/playwright/tests/eventListing.spec.ts - [x] Code coverage Next Build has unit tests for all of their templates. Coverage stats can be found via ‘yarn test:coverage’. As of 11/7/2024, the current coverage is: All files % Stmts: 88.17 | 80.07 | 84.73 | 87.77 | % Branch 80.07 % Funcs 84.73 % Lines 87.77 - [x] Endpoint monitoring playbook This step is not applicable to Next Build’s events and event listing because Next Build does not access any end points. **Not required, but nice to have artifacts** - [ ] **Content source of truth:** link to CAIA Content feedback, such as a content source of truth. - [ ] **Information Architecture spec:** link to CAIA IA feedback, such as an IA spec. ##### Platform actions - [x] [Slack thread with VFS team](https://dsva.slack.com/archives/C01SR56755H/p1730488884177999) - [x] Meeting date/time: Friday, November 14, 2024 at 2 p.m. Eastern #### After meeting ##### Platform actions - [ ] Update this ticket with the Zoom recording - Recording link: https://oddball-io.zoom.us/rec/share/APhTRNLOPLjKlLjlne-5_wuJfPuKYrS_4EA0jkH2Mvy4JZuxpy6jN7ReHdcRKrEm.6l2sXOsjCfM282PN - Password: mD=@h!4d ##### VFS actions - [ ] Review the findings tickets and comment on the ticket if there are any questions or concerns - [ ] Close individual findings tickets when the issue has been resolved or validated by your Product Owner. If a team has additional questions or needs Platform help validating the issue, please comment on the issue ticket. - [ ] After launch, [request an accessibility audit from the VA 508 Office](https://depo-platform-documentation.scrollhelp.site/developer-docs/request-support-from-the-va-508-office#RequestsupportfromtheVA508office-AuditRequest). This is required even if no accessibility issues were found during the Staging Review. - [ ] Share ServiceNow ticket number here: ______ - [ ] Close ticket once Privacy, Security, Infrastructure Readiness Review has been completed, VA 508 Office audit is requested, and all other post-Staging actions are complete
NaomiPMC commented 2 weeks ago

To be left in new intakes as Danielle is confirming if there is any CAIA work attached. To be reviewed 11/20/24.

DonMcCaugheyUSDS commented 3 days ago

Thank you for participating in the Architecture Intent meeting.

No strong recommendations, but a couple of suggestions:

timcosgrove commented 2 days ago

Thank you for participating in the Architecture Intent meeting.

No strong recommendations, but a couple of suggestions:

  • see if there is any practical way to distinguish static and auth'd pages in Google Analytics so we can better understand usage of static pages in aggregate
  • look into how static pages are cached inside VA.gov systems to get a better understanding the real-world impact of increased load times for content build pages (i.e. effective caching inside the VA network may largely eliminate the ~70ms increase load time for content build pages)

Thank you for giving us great feedback and having the discussion yesterday!

We have created https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19925 to track analytics segmenting of CMS-based VA.gov traffic vs non-CMS.

We have created https://github.com/department-of-veterans-affairs/va.gov-cms/issues/19927 to track investigation into the caching of static pages inside VA.gov systems, noting that this work may end up being a collaboration between CMS Team and Platform Infrastructure and therefore may end up tracked elsewhere.

We have also raised the discussion of content moderation to mitigate internal security threats CMS content may pose to our PO. They will initiate OCTO-internal discussions about what form that might take.