search

department-of-veterans-affairs / vets-api

API powering VA.gov
https://api.va.gov
Other
210 stars 64 forks source link

restrict running `check-approval-requirements` to PRs on master #19617

Closed rmtolmach closed 2 days ago

rmtolmach commented 2 days ago

Summary

We only need to run this action on PRs going into the master branch. It's possible a team is working from a feature branch. Example: https://github.com/department-of-veterans-affairs/vets-api/pull/19552

I thought we might need it on the parent-helm-charts branch, but ALL of those files are owned by backend-review-group (parent-helm-charts CODEOWNERS) so this extra check isn't necessary.

Related issue(s)

https://dsva.slack.com/archives/C0460N83Y9G/p1732580536226669

Testing done/Screenshots

In this PR when base is master: image

In this PR when I changed the base to a different branch: image

What areas of the site does it impact?

check-approval-requirements workflow

rmtolmach commented 2 days ago

‼️ I changed the base branch to a random branch in order to test that this was working. It added a bunch of reviewers–my bad!! I changed the base back to master and removed everyone. We should be good now.

github-actions[bot] commented 2 days ago

Backend-review-group approval confirmed.

rmtolmach commented 2 days ago

thanks for the reviews!