department-of-veterans-affairs / vets-website

Frontend for VA.gov
Creative Commons Zero v1.0 Universal
243 stars 126 forks source link

Implement one consistent table style across the site #2692

Closed crwallace closed 8 years ago

melwoodard commented 8 years ago

The USWDS bordered table style should be used across vets.gov. This affects:

bshyong commented 8 years ago

Update: I'll fix this issue and https://github.com/department-of-veterans-affairs/vets-website/issues/2693 across the various apps

I did some investigating today and found out that the usage of Foundation in the va_common is clobbering a lot of the USDS styles. My plan of attack is to break out Foundation so that we can import Foundation styles selectively (and remove/comment out ones we don't need, e.g. tables). I'll publish a new version of the gem with those changes and then upgrade all of our existing apps.

bshyong commented 8 years ago

va_common has been updated and published—there are a couple PRs out in the wild across the various apps but once they are merged we should be good to go