search

department-of-veterans-affairs / vets-website

Frontend for VA.gov
Creative Commons Zero v1.0 Universal
243 stars 126 forks source link

On GI Bill "Instituions" page "Refine my search" for institution type doesn't display status #655

Closed alex closed 8 years ago

alex commented 9 years ago

URL: https://www.vets.gov/gi-bill-comparison-tool/institutions/search?utf8=%E2%9C%93&page=1&num_results=9&source=search&military_status=veteran&spouse_active_duty=no&gi_bill_chapter=33&cumulative_service=1.0&enlistment_service=3&consecutive_service=0.8&elig_for_post_gi_bill=no&number_of_dependents=0&online_classes=no&institution_search=Chicago&commit=Search+Schools&page=1&num_results=9&page=1&num_results=9&page=1&num_results=9&page=1&num_results=9&schools=true&state=il&page=1&num_results=9

I have selected the School Institution option, but it still looks like:

screen shot 2015-11-13 at 11 46 15 am
alex commented 9 years ago

(I'm expecting School to show up as selected)

rickleegit commented 9 years ago

@mphprogrammer, pretty sure that this is a product of the bug fix yesterday. Mind having a look? If this will be resolved by the search rewrite, please just note a realistic eta for the deployment of a tested search rewrite.

Thanks!

mphprogrammer commented 9 years ago

Its a product of having the double ids - having both the responsive and regular filters. Rails renders both on the page, even if one is hidden its part of the document. It had been doing this since the release.

rickleegit commented 9 years ago

Ok. Let's figure this out Monday. Will the rewrite help?

On Nov 14, 2015, at 3:10 PM, Marc Harbatkin notifications@github.com wrote:

Its a product of having the double ids - having both the responsive and regular filters.

— Reply to this email directly or view it on GitHub.

mphprogrammer commented 9 years ago

Yup - the rewrite will have no ids in the controls, and incorporate a select box for school features. I've also included tests as I rewrite as part of this process.

rickleegit commented 9 years ago

Perfect! Thanks!!

On Nov 14, 2015, at 3:14 PM, Marc Harbatkin notifications@github.com wrote:

Yup - the rewrite will have no ids in the controls, and incorporate a select box for school features.

— Reply to this email directly or view it on GitHub.

emilyville commented 8 years ago

@rickleegit can we close this out? I'm guessing so because it's way old.