Open jorabin opened 8 months ago
Re: the proto, the protobuf is internal to this library. It is unrelated to the other protobuf definitions. The protobuf used here is meant only for JNI serialization. The user of this library is free to use any serialization method to communicate with the helpers, including the protobuf definition found in the protobufs
repo.
@rsinha we moved the protobufs to another repo. Is this still relevant?
@rsinha we moved the protobufs to another repo. Is this still relevant?
which repo did you move to?
@jorabin The protobufs are in https://github.com/derecalliance/protobufs. The issue needs to be updated as protobufs are no longer duplicated -- the other asks are still relevant.
@jorabin The protobufs are in https://github.com/derecalliance/protobufs. The issue needs to be updated as protobufs are no longer duplicated -- the other asks are still relevant.
yes I know :) I thought @ehanoc was saying they'd been moved somewhere else.
Picking up from #2.
Assuming Java code is removed (see #8), and put elsewhere, require clear build instructions for the remaining Rust library.
Needs usage examples.
Needs a test suite.
Make sure that
proto
definition is exposed to language specific dependencies (it's duplicated at present) so they can pick up on the current version.