search

derekkraan / horde

Horde is a distributed Supervisor and Registry backed by DeltaCrdt
MIT License
1.3k stars 102 forks source link

Adds Horde.Registry.delete_meta/2 #187

Closed weakwire closed 4 years ago

derekkraan commented 4 years ago

Hi @weakwire , thanks for the PR. Can you tell me why you need this feature? (And why, for example, put_meta(key, nil) is not sufficient).

The reason I'm asking is because we would like to keep API compatibility with Elixir.Registry, and you will notice that there is no delete_meta on that module.

weakwire commented 4 years ago

You are right. I was not aware that put_meta(key, nil) cleans up the key from the registry. I assumed it just assigns a new value. Maybe a documentation update here would be useful.

derekkraan commented 4 years ago

@weakwire Could you submit a PR to improve the documentation as you've described?

Thanks Derek