search

derpierre65 / BetterStreamChat

5 stars 4 forks source link

Bug Fix #24

Closed cyfung1031 closed 1 year ago

cyfung1031 commented 1 year ago

No functional changes. Just Bug Fixing.

  1. For YouTube, previous coding is message.innerHTML = Helper.BTTV.replaceText(message.innerText); which led the emoji in messages being omitted.

    With BetterStreamChat

    Without BetterStreamChat

    ( Example Video: https://www.youtube.com/watch?v=MSSKKntjOEU )

  2. innerText was wrongly used such that it leads to incompatibility to YouTube Super Fast Chat

    As my script would hide the message initially for some reasons, your script reads its innerText would just read as empty text. The correct way is textContent which is fully supported in all modern browsers. Every time you read innerText, it will check the DOM tree whether it is visible or not. This makes the script slower. textContent is independent of DOM node tree.

  3. I found that the script version is 1.3.4 in the manifest. updated to 1.3.5.

    You might further update it to 1.3.6 due to the bug fixing.

  4. The element naming "iron-dropdown" and "paper-item" are quite old. The current naming is "tp-yt-iron-dropdown" and "tp-yt-paper-item". That's why in chrome extension website everyone is asking where is the option page. Now the setting page comes back.

Remarks

Since I am not sure whether this project will update or not, as the last update (to 1.3.5) is already a year ago. I uploaded the chrome extension version in https://github.com/cyfung1031/BetterStreamChat/tree/unpacked

derpierre65 commented 1 year ago

thanks for the fixes
your youtube menu fix was not completly, it only worked when you open the menu for the first time
youtube remove all html elements and re-create the elements, i have added an observer to re-create the menu item.
1.3.6 version is on review on firefox & chrome now.