search

derpierre65 / BetterStreamChat

5 stars 4 forks source link

fix: 12:00 AM for 24 hour clock #29

Closed sn-o-w closed 1 year ago

sn-o-w commented 1 year ago

Otherwise, a timestamp like "12:00 AM" would be misdisplayed as "12:00"

cyfung1031 commented 1 year ago

According this, 12 AM = 00. 01 ~ 11 AM = 01 ~ 11. 12 PM = 12. 01 ~ 11 PM = 13 ~ 23

So not just 12 AM. 12 PM remains "12" too.

cyfung1031 commented 1 year ago

Sorry I don't know how to add edit to others' PR. just based on your version and added 1 commit and create another PR.

derpierre65 commented 1 year ago

i will merge #30 tomorrow and push a new release

sn-o-w commented 1 year ago

I'm fine if there's another and better solution as long as it fixes the issue. 👍