designatednerd / DNSSwipeableTableCell

UITableViewCell subclass to add multiple buttons to a swipe-under menu like iOS 7 Mail.
MIT License
175 stars 24 forks source link

DNSSwipeableTableCell interferes with interactivePopGestureRecognizer #6

Closed mergesort closed 10 years ago

mergesort commented 10 years ago

I believe the panGesture recognizer is interrupting the interactivePopGestureRecognizer's abililty to pop and go back. I replaced a regular UITableViewCell with it, and it went back to working.

I believe the code responsible for it is inside - (void)panThisCell:(UIPanGestureRecognizer *)recognizer inside the UIGestureRecognizerStateChanged case, more specifically:

if (!panningLeft) {
                CGFloat constant = MAX(adjustment, 0);
                if (constant == 0) {
                    [self resetConstraintContstantsToZero:YES notifyDelegateDidClose:NO];
                } else {
                    self.contentViewRightConstraint.constant = constant;
                }
            } 

Thanks, Joe

designatednerd commented 10 years ago

It's possible it's there, but it's also possible it's something I need to deal with in my favorite overly verbose delegate method, gestureRecognizer:shouldRecognizeSimultaneouslyWithOtherGestureRecognizer:. I'm hoping to take a look at this either later this week or early next week.

mergesort commented 10 years ago

Yep, I solved it this way, want me to submit a PR to add it?

designatednerd commented 10 years ago

@mergesort Yes please. Thanks!

mergesort commented 10 years ago

Submitted. https://github.com/designatednerd/DNSSwipeableTableCell/pull/8

designatednerd commented 10 years ago

This has been closed, finally.