search

designly1 / nextjs13-progress

An implementation of n-progress for use with the Next.js 13 app router.
MIT License
12 stars 5 forks source link

modified InternalLinkProps to include children and className #3

Closed Abdulrahim2567 closed 6 months ago

Abdulrahim2567 commented 6 months ago

Hello sir Jay Simons I really loved your solution which allowed me use Nprogress again after switching to the app router of NextJS 13 however, in using your solution I encountered a problem where Typescript throws me an error when I try to pass in children to the Link component imported from import { Link } from "nextjs13-progress"; because he Link component doesn't accept children or className by default as props so I simulated a solution by modifying the props and it worked just fine. Hence, I decided to created a PR with the solution in hopes that you could adopt it and updated the NPM package.

while in wait for an accepted PR from you,

Thanks a lot for the new solution.

Abdulrahim2567 commented 6 months ago

just a little more mod to the children types, added an option string types instead of just a ReactNode

designly1 commented 6 months ago

just a little more mod to the children types, added an option string types instead of just a ReactNode

Hi, thank you for your contribution! I was aware of this problem and I had it on the back burner. I really appreciate your help :-) Merged, closed and version bumped to 1.3.0 on NPM.

designly1 commented 6 months ago

just a little more mod to the children types, added an option string types instead of just a ReactNode

Hi, I encountered an error during build time. Please see https://github.com/designly1/nextjs13-progress/issues/4#issue-2306706894. Let me know what you think. Thanks!