search

desihub / speclite

Lightweight utilities for working with spectroscopic data
14 stars 19 forks source link

Padding method not propagated for filter group #64

Closed dkirkby closed 3 months ago

dkirkby commented 3 years ago

Calling pad_spectrum on a FilterSequence does not propagate a non-default method arg when pad_spectrum is called on the individual filters. The solution is to add method below:

        for response in sorted_responses:
            padded_spectrum, padded_wavelength = response.pad_spectrum(
                padded_spectrum, padded_wavelength, method)

Thanks to Anand for reporting this.

weaverba137 commented 4 months ago

@araichoor @dkirkby, this seems like a trivial issue to fix. Is there a hidden reason why there is no PR associated with this?

dkirkby commented 3 months ago

No, we just need someone to make the PR and test it.

weaverba137 commented 3 months ago

Will do.