Updates in preparation for next release

desihub / speclite

Lightweight utilities for working with spectroscopic data

14 stars 19 forks source link

Updates in preparation for next release #92

Closed weaverba137 closed 3 months ago

weaverba137 commented 3 months ago

This PR:

Closes #89
Closes #88
Closes #64
Closes #34
Closes #25
Restores test coverage to 100%.
Fixes the speclite_benchmark command.

weaverba137 commented 3 months ago

Additional commentary: I tried to make as few changes as possible in this PR, and I think this is a release candidate for v0.20. However, I recommend that subsequent to this PR and tagging v0.20 that a major overhaul of the package infrastructure be performed, e.g. removing astropy_helpers, minimizing the use of setup.py. This isn't hard, since there are plenty of examples already in the Astropy and DESI ecosystems.

weaverba137 commented 3 months ago

Bonus: I have been able to fix #25. For both #25 and #34, the issue was that FilterSequence.pad_spectrum was not passing the axis or method keywords to FilterResponse.pad_spectrum. That's all!

weaverba137 commented 3 months ago

Thank you @dkirkby. I'll leave this open longer in case anyone wants to take a look: @segasai, @moustakas, @araichoor.

weaverba137 commented 3 months ago

Thank you everyone, merging and tagging momentarily.

moustakas commented 3 months ago

Could v0.20 be installed at NERSC, please?

module spider speclite

--------------------------------------------------------------------------------------------------------------------
  speclite:
--------------------------------------------------------------------------------------------------------------------
     Versions:
        speclite/main
        speclite/master
        speclite/v0.13
        speclite/v0.15
        speclite/v0.16
        speclite/v0.17
        speclite/v0.18
        speclite/v0.19

weaverba137 commented 3 months ago

Done, but only for desiconda/20240425-2.2.0.