dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2023 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
15 stars 36 forks source link

add: New Project - Notes App #46

Closed adhikari-dikshant closed 11 months ago

adhikari-dikshant commented 11 months ago

Describe your change:

Checklist:

ATTACH SCREEN-SHOTS

Before After
Screenshot (46) Screenshot (47)
netlify[bot] commented 11 months ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit c697508bec7e8660de0f54b6c21906b07ae1e2f9
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/6524cf26fab1860008161dba
Deploy Preview https://deploy-preview-46--frontend-database.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 11 months ago

Pull Request Review - Summary

Hey there! 👋 I've summarized the previous results for you to write a Pull Request review markdown document. Let's get started!

Changes

  1. Changed the structure of the 'tags' array in the 'ProjectList.json' file. It is now formatted as a list with each tag on a new line.
  2. Changed the Description of the project 'Responsive Navigation Menu for your company's landing page.' at line 162.
  3. Added tags html, css, and js to the project 'Typing Progress Bar' at line 162.
  4. Added tags html, css, and js to the project 'Stock purchase' at line 170.
  5. Added tags html, css, and js to the project 'Coffee-Bean' at line 178.
  6. Added tags html, css, and js to the project 'Made a basic Calculator' at line 186.
  7. Added tags html, css, and js to the project 'Who's that Pokemon' at line 194.
  8. Added tags html, css, and js to the project 'Web Audio Drum Machine' at line 202.
  9. Removed the tag js from the project 'My Portfolio' at line 210.
  10. Removed the tag js from the project 'Gym Landing Page' at line 218.
  11. Added tags html, css, and js to the project 'QR Code Generator' at line 226.
  12. Added tag Dom to the project 'Simon Game' at line 234.
  13. Added tag Dom to the project 'Piano' at line 242.
  14. Added tags html, css, and js to the project 'Mond

Suggestions

  1. In 'ProjectList.json', consider using consistent capitalization for the 'Css' tag. It should be 'CSS' to match the other tags.
  2. In 'ProjectList.json', the 'Description' field should be more descriptive and provide a clear explanation of each project.
  3. In line 330, the tags array is not properly indented. It should be aligned with the other properties.
  4. In line 496, the tags array is not properly indented. It should be aligned with the other properties.
  5. In line 338, the tags array is not properly indented. It should be aligned with the other properties.
  6. In line 508, the tags array is not properly indented. It should be aligned with the other properties.
  7. In line 346, the tags array is not properly indented. It should be aligned with the other properties.
  8. In line 520, the tags array is not properly indented. It should be aligned with the other properties.
  9. In line 354, the tags array is not properly indented. It should be aligned with the other properties.
  10. In line 532, the tags array is not properly indented. It should be aligned with the other properties.
  11. In line 362, the tags array is not properly indented. It should be aligned with the other properties.
  12. In line 544, the tags array is not properly indented. It should be aligned with the other properties.
  13. In line 370, the tags array is not properly indented. It should be aligned with the other properties.

Bugs

No potential bugs found in the code.

Improvements

  1. In 'ProjectList.json', the 'FilePath' field could be refactored to use relative paths instead of '../' notation. This would improve readability and make it easier to navigate the file structure. Here's an example of how it could be rewritten:
    "FilePath": "projects/Example-Project/index.html"
  2. Replaced the single-line tags array with a multi-line array for better readability.

Rating

Overall code rating: 7.5/10

Criteria:

That's it! Feel free to use this summary to write your Pull Request review markdown document. Good luck! 🚀

dev-AshishRanjan commented 11 months ago

You can also checkout our Idea-Arca, the project idea bank for any languages, for open-source contributions.

Happy Contributing season! Keep up the good work!