search

devBanner / devBanner_Frontend

Responsive web page for devBanner (WEB)
https://devbanner.center
Apache License 2.0
10 stars 8 forks source link

Added forbidden character detection and username cookie storing #31

Closed jonasgeiler closed 6 years ago

jonasgeiler commented 6 years ago

Added the forbidden character detection (see #29) and a cookie that stores the username and automatically fills the input field on next page load. (Useful?)

Kimmax commented 6 years ago

Yes I think storing the username is useful, howeeeever we will need to add a cookie bar to comply with the EU Cookie Law

Kimmax commented 6 years ago

There are premade Plugins tho Would you mind adding that to this PR? :)

jonasgeiler commented 6 years ago

You mean premade Plugins for some cookie popups?

jonasgeiler commented 6 years ago

Should I remove that feature again? I think a cookie popup would kinda destroy the look of the site...

Kimmax commented 6 years ago

It doesn't need to be a popup, a small dismissable bar at the bottom is enough and only needs to be visible at the first vist I kinda like the feature.. We'll probably use cookies one way or another anyways in the future

jonasgeiler commented 6 years ago

Okay there ya go!

cozyplanes commented 6 years ago

Some users may not like the autofill... Not me So how about making a small not disruptive x button in the field? @Skayo

Kimmax commented 6 years ago

Autofill is there one way or another, let's keep it for starters and add an opt out option later on An extra button seems more disruptive to me than autofill, we could just clear the field on focus

cozyplanes commented 6 years ago

Nonono You mean when I typed the subtext wrong (like a spelling), touch somewhere else, and touches the input field again, it's gone? What a horrible experience. Add sth like this seems better FOR ME.

jonasgeiler commented 6 years ago

How about only show the x-Button if the script autofilled the field? Otherwise never show it.

cozyplanes commented 6 years ago

Well showing the x button only when there is some text in the field may be better (i mean, you will put the button anyway...)

Kimmax commented 6 years ago

You were talking about how the AUTOFILL might not be wanted by users. So I responded to that. No context to invalid input at all.

(i mean, you will put the button anyway...)

you have no right to force him to do anything. What you can do is to refuse a PR. That's it. In my opinion you should practice to clearly communicate your wishes or you end up as the Project manager X that's getting ranted about.

jonasgeiler commented 6 years ago

There ya go!