search

devbisme / kinparse

A Parser for KiCad EESCHEMA netlists.
MIT License
23 stars 11 forks source link

Fix tests and CI #9

Closed brainstorm closed 5 years ago

brainstorm commented 5 years ago

Hello @xesscorp,

You are absolutely right about issue https://github.com/xesscorp/kinparse/issues/8, it was me messing up in the Jupyter notebook. Therefore, since I "wasted" your time debugging my issue, I felt compelled to return the favor and fix your testing and CI setup a bit.

I removed the hardcoded paths and I've put together the needed tox environment to run it all on TravisCI. All that needs to be done is activate the TravisCI github webhook since I'm not owner of your repo ;)

Hope that helps for this repo and all your other projects and so you can catch regressions and other bugs early as your creations get more popular.

Sorry again for my oversight and happy new year!

Cheers!

xesscorp commented 5 years ago

Thanks for adding TravisCI to the project, @brainstorm! I did have to change the Python 3.7 tests to Python 3.6 in order to pass (Travis said it couldn't load the 3.7 file).