search

devcontainers / spec

Development Containers: Use a container as a full-featured development environment.
https://containers.dev
Creative Commons Attribution 4.0 International
3.61k stars 231 forks source link

[docs] Make merge logic table less confusing #284

Closed ronakj closed 1 year ago

ronakj commented 1 year ago

x is confusing in the supported fields entries because someone can assume that it means not supported. ✓ is much less confusing.

bamurtaugh commented 1 year ago

Thanks for taking the time to open this PR @ronakj!

We definitely want to make sure our references are as clear as possible. I suggest we keep this PR open to see if other folks from the community share any thoughts.

avidal commented 1 year ago

So, all this changes is x to ✓? If so, sounds good to me.

bamurtaugh commented 1 year ago

Thanks again for opening! Since it sounds like we generally think this is reasonable, we'll also just need a PR to https://containers.dev/: https://github.com/devcontainers/devcontainers.github.io/blob/gh-pages/_implementors/spec.md?plain=1. If you can open that up @ronakj, I'm happy to review and then merge both PRs.

ronakj commented 1 year ago

@bamurtaugh Created this PR in the other repo https://github.com/devcontainers/devcontainers.github.io/pull/286.

I also added gpu option for hostRequirements to this PR, as it was missing here but present in the other repo.

bamurtaugh commented 1 year ago

@samruddhikhandale would you mind reviewing too? I think merge requires approval from someone in the maintainers org.