search

develodesign / vsf-payment-paypal

Paypal payment module for Vue Storefront
MIT License
45 stars 34 forks source link

Potential ssr memory leak #159

Closed didkan closed 3 years ago

didkan commented 3 years ago

https://github.com/vuestorefront/vue-storefront/issues/5917 Bases on the above issue there is a potential server side memory leak here: https://github.com/develodesign/vsf-payment-paypal/blob/956d5352b2f7963fdfd4543f1f3fbbb7d6b83814/hooks/afterRegistration.ts#L16-L22

didkan commented 3 years ago

Just noticed the if (!isServer) condition now, so this is probably not an actual issue.

But VSF has deprecated the use of Vue.prototype.$bus so it should probably be fixed anyway.

dimasch commented 3 years ago

@didkan Thanks a lot!