search

devinross / tapkulibrary

tap + haiku = tapku, a well crafted open source iOS framework
http://devinross.com/tapku/documentation
MIT License
3.9k stars 653 forks source link

Coverflow: Issue when scrolling quickly to either end of overflow #195

Open jeremyeccles opened 12 years ago

jeremyeccles commented 12 years ago

Forgive me if this is a known issue. I didn't have the time to look through everything - I just fixed it.

When quickly scrolling past the first or last image in coverflow there is a bug that causes the first or last image to repeatedly register as having been brought to the front. Add the following method to TKCoverFlowView.m to fix it:

- (void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView{
    gliding = NO;
    isDragging = NO;
}

Thanks for some sweet code. Coverflow is going in an app that ships next week. Let me know if you want to know more about it.

pceccato commented 12 years ago

If you have fixes or improvements to the code why not fork the code and create a pull request?

Paul

On Fri, Oct 12, 2012 at 2:47 PM, Jeremy Eccles notifications@github.comwrote:

Devin,

Forgive me if this is a known issue. I didn't have the time to look through everything - I just fixed it.

When quickly scrolling past the first or last image in coverflow there is a bug that causes the first or last image to repeatedly register as having been brought to the front. Add the following method to TKCoverFlowView.m to fix it:

  • (void)scrollViewDidEndDecelerating:(UIScrollView *)scrollView{ gliding = NO; isDragging = NO; }

Thanks for some sweet code. Coverflow is going in an app that ships next week. Let me know if you want to know more about it.

— Reply to this email directly or view it on GitHubhttps://github.com/devinross/tapkulibrary/issues/195.