search

devonfw-forge / devonfw-microservices

Apache License 2.0
2 stars 7 forks source link

istio and keycloak integration #32

Open GuentherJulian opened 3 years ago

GuentherJulian commented 3 years ago

Integration of Istio and Keycloak features

hohwille commented 3 years ago

@GuentherJulian is this PR incomplete as you prefixed it with WIP:? BTW: This is github and not gitlab, next time please use this github feature: https://github.blog/2019-02-14-introducing-draft-pull-requests/

GuentherJulian commented 3 years ago

@GuentherJulian is this PR incomplete as you prefixed it with WIP:? BTW: This is github and not gitlab, next time please use this github feature: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@hohwille It's not finished yet. I am still working on it and would like to add some additional features to be able to check permissions in code. I will convert it in draft and let you know when it is ready.

GuentherJulian commented 3 years ago

@hohwille Can you check this PR again? I have added an example showing the validation of JWTs in Istio and within the application.

lilliCao commented 3 years ago

Also, I personally think we should put the code in a separated branch instead of merging to main in case we want to test other stuffs with the ref application @GuentherJulian @hohwille

hohwille commented 3 years ago

Also, I personally think we should put the code in a separated branch instead of merging to main in case we want to test other stuffs with the ref application @GuentherJulian @hohwille

Maintaining different branches in parallel does not work on the long run. In such case it is better to use a feature toggle but keep a single main branch maintained.