search

devongovett / exif-reader

A small EXIF image metadata reader
MIT License
145 stars 22 forks source link

refactor: Switch to typescript #20

Closed p-kuen closed 2 months ago

p-kuen commented 2 years ago

Use a typescript implementation to support automatic type generations. Tests run successfully.

lovell commented 1 year ago

Thanks for taking the time to open a PR. I'm unsure it will be merged as this package is relatively low-maintenance, and switching to TypeScript is not a priority.

For those who do use TypeScript, the @types/exif-reader package is available with suitable definitions.

https://www.npmjs.com/package/@types/exif-reader

p-kuen commented 1 year ago

Thanks for your comment. Although it is clear that typescript migration is not a high priority I don't think this should be a reason for not doing it. Especially because the migration is pretty trivial and all the tests were successful (1y ago). If this means I should close the PR, please let me know. Thanks.